help wantedneeds/researchtopic/performance
Repository metrics
- Stars
- (5,615 個のスター)
- PR merge metrics
- (PR metrics pending)
説明
Background
PR #1970 was opened by @ashmaroli to attempt to reduce the number of allocated empty strings created by Nokogiri.
This PR was merged and released in v1.11.0.rc1.
@ashmaroli repeated his profiling (I think using the memory_profiler gem) and commented that it didn't seem to have an effect.
Actions
- reproduce the original memory profliling scenario - @ashmaroli please help with this
- determine whether the patch can be tweaked to reduce the number of allocated strings or no
- make a recommendation - revert or re-patch
Retrospecting
I should have asked for more details from @ashmaroli when he submitted the PR to reproduce his results, and demonstrate improvement, before merging. This would have allowed me to ask questions at a more appropriate time.