someshkar/covid19india-cluster

Highlighting the Patient Number Searched

Open

#177 opened on 2020年3月30日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)JavaScript (991 stars) (666 forks)batch import
good first issue

説明

Hi! While this looks amazing, calling out a small issue that I felt while searching patient was as follows:

  • The resolution of the graph can be reduced a little, often the patient searched goes out of screen (SS-1 as below), image I had to zoom out manually to see the search result. (SS-2 as below) image

  • The Patient searched can be highlighted with a light background color as well to enhance the visiblity.

コントリビューターガイド

技術スタック
javascript
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
basic understanding of graph rendering in JavaScript
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
Look at the graph component files, likely in the src directory, to understand how patient nodes are rendered and zoom is handled. The issue requests two changes: reducing graph resolution to prevent the searched patient from going off screen, and highlighting the searched patient with a light background. Consider adjusting the camera/zoom behavior to center on the selected node, and adding a CSS class or style to highlight the node. Check if there are any existing similar implementations or comments from maintainers.