solidjs/solid-docs

[Content]: Typescript "Event handling" and "Advanced JSX attributes and directives" sections

Open

#569 opened on 2024幎3月3日

GitHub で芋る
 (0 comments) (2 reactions) (0 assignees)MDX (363 forks)github user discovery
good first issuehelp wantedplannedsolid

Repository metrics

Stars
 (289 stars)
PR merge metrics
 (PR metrics pending)

説明

📚 Subject area/topic

Typescript "Event handling" and "Advanced JSX attributes and directives" sections

📋 Page(s) affected (or suggested, for new content)

https://docs.solidjs.com/configuration/typescript#event-handling https://docs.solidjs.com/configuration/typescript#advanced-jsx-attributes-and-directives https://docs.solidjs.com/configuration/typescript#custom-event-handlers

📋 Description of content that is out-of-date or incorrect

  • "Event handling" section and "custom event handler" section are split up, it makes more sense for these to be together
  • "custom event handler" section is currently under "Advanced JSX attributes and directives" along with "Forcing properties and custom attributes" and "Custom directives". I'm not sure it makes sense to have these split up. I feel like it would be easier to find if they were all just part of the list of API types. @LadyBluenotes let me know what you think about this one please.
  • "Forcing properties and custom attributes" and "Custom directives" are not a high enough level heading to show up in the page outline
  • "custom event handler" should be renamed since it also covers standard events, it is really just how to type on: both custom and standard events
  • standard events for on: are not included in SolidJS by default so the types have to be added manually, it should probably just be a subsection rather than a callout

🖥 Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response

コントリビュヌタヌガむド