solana-labs/solana

Balances are collected for transactions within a TransactionBatch that aren't locked or executed

Open

#32,346 opened on 2023年6月30日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)Rust (12,651 stars) (3,950 forks)batch import
communityenhancementgood first issuevalidator

説明

Problem

When collecting balances before and after execution in BankingStage, the balances for transactions within a TransactionBatch that didn't execute still get collected even though the state didn't change.

There is likely a slight performance hit for doing this, especially with batches that contain many transactions that failed to lock.

Proposed Solution

When collecting pre-balances, check the lock results and only collect pre-balances for transactions that lock successfully. When collecting post-balances, check the execution results and only collect post-balances for transactions that executed.

コントリビューターガイド

技術スタック
rust
領域
performanceblockchain
Issue 種別
performance
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
RustSolana BankingStageTransaction batch processing
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
35
調査方針
Start by exploring the BankingStage code in the Solana repository, likely under 'runtime/src/banking stage.rs' or similar. Look for where pre balances and post balances are collected, and understand how TransactionBatches are processed. Then implement the proposed check to skip balance collection for transactions that did not lock or execute. Refer to the issue comments for any further context.