solana-labs/solana

validator uses more memory than expected when metrics are enabled

Open

#24,319 opened on 2022年4月13日

GitHub で見る
 (26 comments) (0 reactions) (1 assignee)Rust (12,651 stars) (3,950 forks)batch import
do-not-closegood first issue

説明

Problem

80GB difference between RUST_LOG=solana=info and RUST_LOG=solana=warn for RPC nodes.

Proposed Solution

Relevant question.. is the channel that the metrics are sending to really large? Could there be some large amount of outstanding sends which each is taking some memory and state?

Debug and find why. Possibly reduce the occurrence of spammy metrics.

コントリビューターガイド

技術スタック
rust
領域
performanceobservability
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
active
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Rust programmingbasic understanding of Solana validator architecture
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
Investigate the memory increase when metrics are enabled. Look at the metrics sending channel in the Solana validator code (likely in `validator/src/` or `metrics/`). Profile memory usage with tools like `heaptrack` or `valgrind` to identify where the excess memory is allocated. Check if outstanding sends in the metrics channel are accumulating. Reduce spammy metrics by filtering or batching. Review comments from the issue for additional hints.
validator uses more memory than expected when metrics are enabled · solana-labs/solana#24319 | Good First Issue