solana-labs/solana

`solana vote-account` authorized-voter display is not clear

Open

#11,273 opened on 2020年7月29日

GitHub で見る
 (6 comments) (0 reactions) (0 assignees)Rust (12,651 stars) (3,950 forks)batch import
good first issue

説明

Problem

We currently display a vote account info on the CLI as follows:

$ solana vote-account vote.json
Account Balance: 0.02685864 SOL
Validator Identity: 7hguFUbg1pbkSppuwfZ1i9n9Wrqs22J4nLRepGnjvniW
Vote Authority: {2: "7hguFUbg1pbkSppuwfZ1i9n9Wrqs22J4nLRepGnjvniW"}
Withdraw Authority: 7hguFUbg1pbkSppuwfZ1i9n9Wrqs22J4nLRepGnjvniW
Credits: 0
Commission: 100%
Root Slot: ~
Recent Timestamp: BlockTimestamp { slot: 0, timestamp: 0 }

The line Vote Authority: {2: "7hguFUbg1pbkSppuwfZ1i9n9Wrqs22J4nLRepGnjvniW"} is not clear what the two values represents, which is: epoch: authorized_voter. So if you authorize a new voter, it should be reported there, keyed to the epoch it changed.

Proposed Solution

  • Change Vote Authority line to just display the pubkey of the vote auth, same format as withdraw auth.
  • Add a separate line for the epoch change data, like: Vote Authority last changed during Epoch: [epoch]

コントリビューターガイド

技術スタック
rust
領域
cliblockchain
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Basic RustFamiliarity with CLI output formatting
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
The issue describes a clear feature request to improve the CLI output of `solana vote account`. The current display shows `Vote Authority: {2: "pubkey"}` which is unclear. The proposed solution is to change it to display the pubkey directly like the withdraw authority, and add a separate line for the epoch change data. To implement, look at the CLI code responsible for displaying vote account info, likely in the Solana CLI source (e.g., `cli/src/vote.rs` or similar). Modify the formatting to match the proposed output. Check existing comments for any additional context or partial implementations.