slackapi/hubot-slack

SlackBot#send() support for a callback function

Open

#473 opened on 2018年4月13日

GitHub で見る
 (0 comments) (6 reactions) (0 assignees)CoffeeScript (2,339 stars) (637 forks)batch import
enhancementgood first issue

説明

Description

in order to know anything about a message after it has been sent, there needs to be a way to run a callback after the chat.postMessage() method completes.

it seems that the Response#send() (from Hubot core) method will invoke the adapter's send() method with the final item in the messages... array set to a function, if the user's script specified one.

this means that all we need to do is pass that callback function into the SlackClient#send() method and make sure it's used as the callback (we can set a default value of a noop function if not).

this support should also be extended to reply() and setTopic().

this would unlock use cases such as #91

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

コントリビューターガイド

技術スタック
nodejsjavascript
領域
apibackend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Understanding of Hubot adapter patternBasic JavaScript/Node.js
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Look at the send method in the SlackBot adapter (likely in src/slackbot.coffee). Implement a callback parameter that defaults to a noop function and pass it to the underlying SlackClient.send() call. Also update reply() and setTopic() similarly. Refer to Hubot's documentation on Response#send for how the callback is passed.