[ENH] merge `skchange` into `sktime` · sktime/sktime#9636

(11 comments) (0 reactions) (0 assignees)Python (7,162 stars) (1,192 forks)batch import

enhancementgood first issueimplementing algorithmsmodule:detection

説明

skchange seems abandoned by its maintainers now, but has a number of nice detection algorithms based on sktime. https://github.com/NorskRegnesentral/skchange

FYI @tveten, @johannvk, is this accurate?

I would suggest to merge skchange completely into sktime to ensure that it remains maintained.

For this, the contents of the skchange directory can be moved into the detection directory entirely.

The one major issue are likely the tests, which in skchange are somewhat custom; in sktime, TestAll classes either replace the tests, or may have to be added. This should be investigated.

If it is possible, it would be nice to maintain attribution to @Tveten and @johannvk in the PR, but I am not sure if this is possible beyond just adding them in authors tags and attributes.

コントリビューターガイド

技術スタック: pythonpandasnumpyscikit learn
領域: machine learningdata
Issue 種別: feature
難度: 5
推定時間: over 1 week
活動状況: needs maintainer response
明確さ: mostly clear
前提条件: familiarity with sktime codebaseknowledge of change point detection algorithmsexperience with pytest test framework
初心者向け度: 20
調査方針: Examine the skchange repository (https://github.com/NorskRegnesentral/skchange) to list all detection algorithms and understand their dependencies. Plan a migration of the skchange directory into sktime's detection directory, addressing the custom test infrastructure by either adapting the existing TestAll classes or adding new ones. Ensure maintainer attribution by including @Tveten and @johannvk in author tags and documentation. Investigate the test suite compatibility as noted by maintainers in the issue comments.