sindresorhus/update-notifier

Run in child process instead of lazy loading every dependency

Open

#210 opened on 2021年7月26日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)JavaScript (1,800 stars) (164 forks)user submission
enhancementhelp wanted

説明

Not a big fan [of lazy loading], but I've seen update-notifier as a require time offender when profiling various things. The idea of update-notifier is that it should have no impact on the consumer. It's just an added bonus, not critical. https://github.com/yeoman/update-notifier/pull/82#issuecomment-225636213

I may be wrong, it seems to me that this change was made simply to hide the package from the very initial load but in practice every dependency is still loaded right after.

update-notifier already uses a child process to do the checking, so I think it'd be best to do the whole thing there.

Related:

コントリビューターガイド

技術スタック
javascriptnodejs
領域
cliperformance
Issue 種別
performance
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Node.js child processesupdate notifier internals
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
Review the current implementation in index.js, especially the child process call at line 98. Understand how lazy loading currently works by examining the require statements. Then, design a solution where the entire update check logic runs in a child process, so dependencies are not loaded in the main process. Consider testing and edge cases.
Run in child process instead of lazy loading every dependency · sindresorhus/update-notifier#210 | Good First Issue