sindresorhus/type-fest

Jsonify makes Record<string, any> disappear

Open

#667 opened on 2023年8月24日

GitHub で見る
 (7 comments) (0 reactions) (0 assignees)TypeScript (12,328 stars) (471 forks)batch import
enhancementhelp wanted

説明

Here's a TS Playground:

import type { Jsonify } from "type-fest";

type Data = Jsonify<{
  payload: Record<string, any>;
}>;

declare const d: Data;
console.log(d.payload) // <-- Property 'payload' does not exist on type 'JsonifyObject<{}>'.

This feels like a bug to me. It's causing an issue for me in the upcoming version of Remix: https://github.com/remix-run/remix/issues/7246

My current workaround is to change the type to unknown instead of any (https://github.com/edmundhung/conform/pull/272 which will hopefully be merged soon). I think is the proper thing to do, but sometimes that's hard because you may not control the type. I think it's more correct to keep the record around on the type.

コントリビューターガイド

技術スタック
typescript
領域
developer experience
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Basic TypeScriptUnderstanding of type fest
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Investigate the Jsonify type implementation in the source (likely source/jsonify.ts). The issue demonstrates that Jsonify<Record<string, any>> resolves to an empty object. The root cause is likely in the handling of index signatures in mapped types. Consider how the type can preserve the Record shape. Also review the linked Remix issue for context. Add a test to cover this case.