sindresorhus/globals

Copy missing globals from `builtin` to `es*`

Open

#140 opened on 2018年8月28日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)JavaScript (587 stars) (132 forks)user submission
enhancementhelp wanted

説明

While investigating why eslint wouldn't pick up the BigInt globals, I noticed eslint does not use builtin like I previously assumed. I'd like to propose to copy any globals missing in either es5, es2015, es2017 but present in builtin to one of those respective environments.

Afterwards, I'd copy back any potential globals from the es* categories to builtin so that it ends up containing all globals from those categories. Alternatively, builtincould be generated dynamically in index.js, I think actually, that'd be my preference to avoid future inconsistency.

コントリビューターガイド

技術スタック
javascript
領域
tooling
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
JavaScript basicsKnowledge of ES5/ES2015/ES2017 globalsFamiliarity with the globals package structure
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
55
調査方針
First, examine the current globals definitions in the repository (likely in globals.json or similar files) to understand the structure of `builtin`, `es5`, `es2015`, and `es2017`. Compare the sets to identify missing globals. Then, review the issue comments for any proposed approaches, particularly the suggestion to generate `builtin` dynamically. The implementation could involve writing a script to copy and synchronize globals, ensuring consistency. Finally, consider testing the changes with ESLint to verify that globals like `BigInt` are correctly recognized.