`explicit-length-check`: ignore variables with non-array properties? · sindresorhus/eslint-plugin-unicorn#1266

(1 comment) (1 reaction) (0 assignees)JavaScript (5,022 stars) (468 forks)user submission

bughelp wantedtypes

説明

if (
  dimensions.width &&
  dimensions.height &&
  dimensions.length // violation reported by unicorn/explicit-length-check
) { }

In this example, packagingData.dimensions is an object, and length could be a string.

As a heuristic to avoid false positives with detecting length or size on variables that are not actually arrays, could we ignore variables that have non-array properties? For example, an array does not have a width property, so if we see that used, we would assume dimensions is not an array, and ignore it.

コントリビューターガイド

技術スタック: javascriptnodejs
領域: tooling
Issue 種別: feature
難度: 3
推定時間: half day
活動状況: stale
明確さ: mostly clear
前提条件: JavaScriptESLint rule APIAST basics
初心者向け度: 45
調査方針: Investigate the current implementation of the `explicit length check` rule in `rules/explicit length check.js`. Understand how it detects violations and consider adding logic to check if the variable has other property accesses that are not typical for arrays (e.g., `.width`, `.height`). Review any existing tests to ensure the heuristic does not introduce false negatives. The issue suggests using a heuristic: if a variable has non array properties, ignore it. Implement this and add appropriate tests.