sindresorhus/element-ready

Use types directly from querySelector, without copying them

Open

#32 opened on 2020年12月29日

GitHub で見る
 (0 comments) (2 reactions) (0 assignees)JavaScript (447 stars) (17 forks)user submission
enhancementhelp wanted

説明

If the selector is 'a', querySelector‘s return type is be HTMLAnchorElement. To achieve the same in element-ready, we had to manually copy its types and adapt them to elementReady

Ideally, instead, we should try to “inherit” directly from the global querySelector so that, if its types are enhanced (via typed-query-selector or natively), element-ready automatically gets upgraded.

Note: We can't use Parameters<typeof querySelector> and such because it doesn't support overloads nor generics.

This has been unsuccessfully tried in #31. More info about it in that PR. A possible solution might be https://github.com/microsoft/TypeScript/issues/33185#issuecomment-526969274

コントリビューターガイド

技術スタック
typescriptjavascript
領域
developer experience
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
TypeScript genericsUnderstanding of querySelector types
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
Review the previous attempt in PR #31 to understand why it failed. Explore the suggested solution from the TypeScript issue comment (microsoft/TypeScript#33185). Investigate if 'typed query selector' can be integrated or if native TypeScript improvements (issue #29037) can be leveraged. Look at the current type definitions in the element ready package to see how types are copied and how they could be inherited from global querySelector.
Use types directly from querySelector, without copying them · sindresorhus/element-ready#32 | Good First Issue