Allow applying debug() to already existing windows · sindresorhus/electron-debug#92

(1 comment) (0 reactions) (0 assignees)JavaScript (776 stars) (56 forks)user submission

enhancementhelp wanted

説明

Since debug only works for future windows, it would be nice to apply the configuration in a retroactive way, so it doesn't depend on the call order (i.e. debug() is called from a plugin or extension out of control).

It also provides another improvement: when using windowSelector it would allow to filter by window reference, not by only its attributes, so this will be possible:

const win = createWindow();
debug({ windowSelector: (w => w === win) });

Implementation would be at the same level than registering the listener for future windows, but iterating on the already existing windows.

コントリビューターガイド

技術スタック: javascriptelectron
領域: developer experience
Issue 種別: feature
難度: 3
推定時間: half day
活動状況: fresh
明確さ: clear
前提条件: Familiarity with Electron app lifecycleBasic JavaScript knowledge
初心者向け度: 60
調査方針: Implement the retroactive debug application by modifying the code in index.js around line 111 where listeners are registered for future windows. Iterate over existing windows using BrowserWindow.getAllWindows() and apply the debug configuration. Consider supporting windowSelector with a function reference to allow window reference comparison.