scribe-org/Scribe-iOS

Refactor to separate out language-specific logic

Open

#323 opened on 2023年5月31日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)Swift (106 forks)auto 404
help wantedrefactor

Repository metrics

Stars
 (167 stars)
PR merge metrics
 (PR metrics pending)

説明

Terms

Issue

What? This issue is for a refactor to separate language-specific logic out from the main base keyboard functionality, generally those under Keyboards/KeyboardsBase/*.swift.

Why? Keeping the codebase cleaner and organized as code may get messy/hard-to-read with language-specific logic sprinkled around, especially as more languages are added over time (and their exceptions and quirks along with them).

How? The general initial idea is to move language-specific logic/checks into the languages' respective Keyboards/LanguageKeyboards/{language}/*.swift files. Discussion on how to implement this exactly can be done in this issue. Work can (and likely will) happen in multiple PR increments as we identify ways on how to refactor.


Other Notes:

コントリビューターガイド