schickling/chromeless

Support for setFileInput() over Proxy

Open

#186 opened on 2017年8月6日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)TypeScript (13,240 stars) (606 forks)batch import
Proxyenhancementhelp wanted

説明

setFileInput() was implemented in #170. However, the setFileInput() does not currently work over the Proxy as expected because files are not transmitted from the local Chromeless instance to the Proxy (something which may be difficult given the AWS IoT 128KB message size limit.)

This issue tracks progress on supporting the Proxy.

Acceptance Criteria

  • Add support to setFileInput() for S3 paths (which means fetching the S3 file, then passing the local disk path from the resulting object to setFileInput()
  • Add support to setFileInput() for URLs
  • if a local file path is provided to setFileInput() we will try to upload it to S3, then pass the S3 path to the Proxy.
await chromeless.selectFile('.uploader', [
  's3://my-bucket/my/object/prefix/file.jpg',
  'http://sweet-site.cool/my-image.jpg'
])

コントリビューターガイド

技術スタック
typescriptaws
領域
testingbackend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
over 1 week
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
AWS S3Chromeless internalsProxy architecture
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
The issue requires implementing support for setFileInput() over the Chromeless Proxy. The main challenge is transmitting files given AWS IoT's 128KB message size limit. The acceptance criteria suggest using S3 paths and URLs, with fallback uploading local files to S3. Reference PR #170 for the initial implementation. Investigate how the proxy currently handles other commands and design a mechanism to fetch S3 objects or HTTP URLs and pass the file path to setFileInput(). Files likely involved are in the Chromeless source code related to the proxy and file input handling.