SparseArray/SparseVector.compact should be split into 2-3 functions · scalanlp/breeze#422

(0 comments) (0 reactions) (0 assignees)Scala (3,453 stars) (690 forks)batch import

good first issuehelp wanted

説明

Currently, SparseArray/SparseVector.compact does two separate things which are usually not intended to be done together. It should be split into three functions:

1: Add a def filter(predicate: T => Boolean): Unit function that allows specifying a predicate which is then used to strip certain values from the array/vector without reallocation.

2: Add a function called def tailor(): Unit that cuts down the memory usage to whatever is required to hold the values.

3: For backwards compatibility, replace the function compact with a function that calls filter(x => x == zero.zero) and then tailor().

コントリビューターガイド

技術スタック: scala
領域: dataperformance
Issue 種別: feature
難度: 3
推定時間: 1-2 days
活動状況: stale
明確さ: clear
前提条件: Scala knowledgeFamiliarity with sparse data structures
初心者向け度: 65
調査方針: Examine the current implementation of SparseArray.compact and SparseVector.compact in the breeze source code (likely under breeze/src/main/scala/breeze/linalg/). Understand how it combines filtering zeros and memory tailoring. Implement a new filter(predicate) method, a tailor() method, and redefine compact to call both. Ensure backward compatibility. Look at existing tests for guidance.