sanic-org/sanic

ASGI exceptions outside handlers should be able to pass status

オープン

#2,718 opened on 2023/03/19

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Python (1,515 件のフォーク)batch import
beginnerhelp wanted

Repository metrics

Stars
 (17,623 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

An exception raised in the lifecycle (but not handler) of a request on an ASGI-served application should be able to pass a status code.


In my experiment, raising a BadRequest in asgi.py will cause the ASGI server return 500 error, instead of 400. This seems out of the scope of this PR, but I am wondering whether we should change the raised error to ServerError or others before we figure out how to let ASGI server return a 400 error.

Originally posted by @ChihweiLHBird in https://github.com/sanic-org/sanic/pull/2606#discussion_r1133448078

コントリビューターガイド