sampotts/plyr

[Improvement] use BEM in a proper way and make plyr CSS more modular.

Open

#567 opened on 2017年4月24日

GitHub で見る
 (7 comments) (1 reaction) (1 assignee)JavaScript (25,318 stars) (2,856 forks)batch import
Help WantedImprovement

説明

Hey,

It's great that you try to use the BEM methodology in your CSS. But your CSS is not fully compatible with BEM. You use BEM syntax (-- for modifiers and __ for elements) which is good, but there is a lot of nested selectors which is against BEM rules.

For example:

.plyr__controls {
    display: flex;
    align-items: center;
    line-height: 1;
    text-align: center;

    // Spacing
    > button,
    .plyr__progress {
    // ... code
   }
}

This it not a valid BEM syntax.

Because of this sometimes overwriting your styles is problematic - one have to deal with specificity issues.

Istead of nesting you should break your styles into smaller modules. Here's a great article on how to deal with common BEM problems: https://medium.com/fed-or-dead/battling-bem-5-common-problems-and-how-to-avoid-them-5bbd23dee319

コントリビューターガイド

技術スタック
cssjavascript
領域
frontend
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Understanding of BEM methodologyCSS specificity knowledgeFamiliarity with plyr CSS structure
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
The issue requests refactoring the plyr CSS to follow BEM methodology properly by removing nested selectors. Currently, the CSS uses nesting that increases specificity. To address this, audit the CSS files (likely under src/css/) and convert nested rules into separate BEM modifier/element classes. For example, replace `.plyr controls > button, .plyr controls .plyr progress` with standalone `.plyr controls` and then use modifiers like `.plyr controls button` if needed. The linked Medium article provides guidance on common BEM pitfalls. Since there is an assignee but no open PR, communication with the maintainer about the current status may be needed before starting.