sampotts/plyr

Muting doesn't work for Vimeo videos in Chrome.

Open

#1,084 opened on 2018年7月3日

GitHub で見る
 (5 comments) (4 reactions) (0 assignees)JavaScript (25,318 stars) (2,856 forks)batch import
BugHelp Wanted

説明

Expected behaviour

To be able to add the muted: true property to the Plyr constructor and the video to be muted.

Actual behaviour

Video plays with sounds in Chrome.

  • Browser: Chrome
  • Version: 67.0.3396.99
  • Operating System: MacOS
  • Version: 10.13.3

Steps to reproduce

Create a div with provider set to vimeo and pass through the vimeo video id with data-plyr-embed-id. Instantiate the video with var hero_video = new Plyr('#hero_player_plyr', { autoplay: true, muted: true, volume: 0, controls: [] });

コントリビューターガイド

技術スタック
javascript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
JavaScriptPlyr library understanding
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
75
調査方針
The issue is that the `muted` property is not being applied to Vimeo videos in Chrome. Investigate the Vimeo provider implementation in Plyr (likely `src/js/providers/vimeo.js`). Check how the `muted` option is passed to the Vimeo embed API. Compare with the HTML5 provider where muting works. Also review the existing comments for additional insights. A potential fix might involve setting the `muted` attribute on the Vimeo iframe or adjusting the Vimeo player parameters.
Muting doesn't work for Vimeo videos in Chrome. · sampotts/plyr#1084 | Good First Issue