saltstack/salt

pythonversion breaks "_info" pattern of other grains.

Open

#59,594 opened on 2021年2月23日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)Python (13,710 stars) (5,508 forks)batch import
Grainsbuggood first issuehelp-wantedseverity-low

説明

Description of Issue

pythonversion grain breaks model of fooversion/release and fooinfo

What I mean by that is that pythonversion is not a simple string or int, but instead a list.

pythonversion:
    - 2
    - 7
    - 5
    - final
    - 0

It should instead be like 'osrelease: 7.9.2009' with the list varient named pythonversion_info.

I'm well aware this is a problematic and backwards incompatible change.

May I suggest adding "pythonrelease: 2.7.5" and "pythonrelease_info: [2, 7, 5, final, 0]" grains? Then at some well documented future date having pythonversion go away.

Setup

Any salt version, at least through 3002.2

Steps to Reproduce Issue

salt-call grains.item pythonversion local: ---------- pythonversion: - 2 - 7 - 5 - final - 0

Versions Report

(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.) salt --versions-report Salt Version: Salt: 3002.2

Dependency Versions: cffi: Not Installed cherrypy: Not Installed dateutil: Not Installed docker-py: Not Installed gitdb: 0.6.4 gitpython: 1.0.1 Jinja2: 2.11.1 libgit2: Not Installed M2Crypto: 0.35.2 Mako: Not Installed msgpack: 0.6.2 msgpack-pure: Not Installed mysql-python: Not Installed pycparser: Not Installed pycrypto: 2.6.1 pycryptodome: Not Installed pygit2: Not Installed Python: 3.6.8 (default, Nov 16 2020, 16:55:22) python-gnupg: Not Installed PyYAML: 3.13 PyZMQ: 17.0.0 smmap: 0.9.0 timelib: Not Installed Tornado: 4.5.3 ZMQ: 4.1.4

System Versions: dist: centos 7 Core locale: UTF-8 machine: x86_64 release: 3.10.0-1160.15.2.el7.x86_64 system: Linux version: CentOS Linux 7 Core

コントリビューターガイド

技術スタック
python
領域
infrastructurebackend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Familiarity with Salt grainsPython development
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
The issue proposes adding two new grains: pythonrelease (string like '2.7.5') and pythonrelease info (list like [2,7,5,'final',0]) to replace the current pythonversion list grain. Start by examining the grains directory (salt/grains/) and the core module (salt/grains/core.py) where pythonversion is likely defined. Look for any discussions in the issue comments about backwards compatibility and deprecation strategies. Implementation should add the new grains, update documentation, and mark pythonversion as deprecated. Consider writing tests in tests/unit/grains/.