saltstack/salt

chattr in file.managed applied at the wrong time

Open

#55,489 opened on 2019年12月2日

GitHub で見る
 (9 comments) (0 reactions) (0 assignees)Python (13,710 stars) (5,508 forks)batch import
buggood first issueseverity-medium

説明

Description of Issue

when using file.managed, an immutable file causes an error. When using attrs: "" - that removes immutable, but only AFTER the content change (that fails, immutable is never removed)

Setup

echo "aa" > /somefile chattr +i /somefile

Steps to Reproduce Issue

state: some file: file.managed: - name: /somefile - attr: "" - content: "xx"

salt runs with: Failed to commit change: [Errno 1] Operation not permitted if the file content is ok, immutable flag gets properly removed

Versions Report

Salt Version: Salt: 2018.3.4

Dependency Versions: cffi: 1.6.0 cherrypy: unknown dateutil: Not Installed docker-py: Not Installed gitdb: 0.6.4 gitpython: 1.0.1 ioflo: Not Installed Jinja2: 2.7.2 libgit2: 0.26.3 libnacl: Not Installed M2Crypto: 0.28.2 Mako: Not Installed msgpack-pure: Not Installed msgpack-python: 0.5.6 mysql-python: 1.2.5 pycparser: 2.14 pycrypto: 2.6.1 pycryptodome: Not Installed pygit2: 0.26.4 Python: 2.7.5 (default, Oct 30 2018, 23:45:53) python-gnupg: Not Installed PyYAML: 3.11 PyZMQ: 15.3.0 RAET: Not Installed smmap: 0.9.0 timelib: Not Installed Tornado: 4.2.1 ZMQ: 4.1.4

System Versions: dist: centos 7.6.1810 Core locale: UTF-8 machine: x86_64 release: 4.15.0-54-generic system: Linux version: CentOS Linux 7.6.1810 Core

コントリビューターガイド

技術スタック
pythonshell
領域
backenddevops
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
basic Salt state knowledgeunderstanding of chattr
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Investigate the `file.managed` state in Salt, specifically in `salt/states/file.py`. The issue is that `attrs` are applied after content changes, causing failure when the file is immutable. The fix should ensure attrs are set before managing content when the file is immutable. Check the order of operations in the ` manage file` function and consider making the attribute change occur first or handling immutable files specially.