rwf2/Rocket

Phase out async_trait macro

Open

#2,684 opened on 2023年12月30日

GitHub で見る
 (5 comments) (6 reactions) (0 assignees)Rust (25,738 stars) (1,645 forks)batch import
acceptedhelp wantedrequest

説明

What's missing?

Rocket currently re-exports the async_trait crate for use with its Fairing (and possibly others). As of rust 1.75.0 this is no longer needed, therefore it would be nice to get rid of this dependency and use actual async functions for these traits.

This generally improves compile times, dependency count and IDE responsiveness.

Ideal Solution

For v0.6, remove async_trait (or put its usage behind a feature) and use async functions directly. This would raise the MSRV to 1.75.0.

Why can't this be implemented outside of Rocket?

This is an integral part of Rocket.

Are there workarounds usable today?

No. You bypass the need for the macro attribute by returning a Box<dyn Future<Output = T> + Send + 'a>, but this is unwieldy.

Alternative Solutions

No response

Additional Context

No response

System Checks

  • I do not believe that this feature can or should be implemented outside of Rocket.
  • I was unable to find a previous request for this feature.

コントリビューターガイド

技術スタック
rust
領域
backend
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
active
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Rust knowledgeAsync programming in RustFamiliarity with Rocket's Fairing trait
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Look for all usages of `async trait` in the Rocket codebase, particularly in the `Fairing` trait and any other traits that currently use the `#[async trait]` attribute. Check the `Cargo.toml` for the `async trait` dependency and its feature flags. The goal is to replace each `#[async trait]` attribute with `async fn` in trait definitions and implementations, and remove the dependency. Consider raising the MSRV to 1.75.0 as mentioned.