rust-lang/rust-clippy

rc_buffer lint is dangerous as it changes runtime behaviour

Open

#6,170 opened on 2020年10月13日

GitHub で見る
 (7 comments) (1 reaction) (0 assignees)Rust (1,391 forks)batch import
C-bugL-suggestiongood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (平均マージ 19d 22h) (30d で 113 merged PRs)

説明

clippy warns if one tries to use a type like Rc<Vec<T>>, e.g.

Arc<Vec<u8>>
^^^^^^^^^^^^ help: try: `Arc<[u8]>`

This is dangerous as creating a Rc<[T]> causes a memcpy of the whole memory area with all the elements, while creating an Rc<Vec<T>> simply copies over the 3 pointers inside the Vec without copying all the elements.

A better suggestion would probably be Rc<Box<[T]>> as that has the same runtime behaviour, but even independent of that it can be useful to have a Vec inside an Rc / Arc in combination with the make_mut() / get_mut() API.

The lint should probably be at least disabled by default.


The same also applies to Rc<String> vs Rc<str>.

コントリビューターガイド