rust-lang/rust-clippy

Support for upcoming `param_attrs` feature

Open

#4,474 opened on 2019年8月30日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
C-enhancementE-needs-testS-needs-discussiongood first issue

説明

param_attrs is likely to be stabilized in Rust 1.39

The param_attrs feature is going to allow lint attributes on function, method and closure parameters:

fn foo(
    a: i32,
    #[allow(unused_variables)] b: i32,
) {}

We should review how this feature ties in with our existing lints. Apparently it did not cause any toolstate breakage when it was merged.

Specifically, we should create a list of lints that could benefit from parameter attributes and then update those lints to make use of them (if that's even required).

コントリビューターガイド

技術スタック
rust
領域
toolingdeveloper experience
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Understanding of Rust's param attrs featureFamiliarity with clippy's lint internals
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
Review the linked Rust PR (https://github.com/rust lang/rust/pull/64010) to understand the param attrs feature. Then, examine clippy's existing lints to identify which ones could benefit from parameter attributes, such as those checking for unused parameters or style issues. Create a list of affected lints and update them to support the new attribute syntax if needed. No current comments or PRs provide further direction.