rust-lang/rust-clippy

Restrict let_and_return if the let binding is large

Open

#420 opened on 2015年10月28日

GitHub で見る
 (6 comments) (5 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
S-needs-discussiongood first issue

説明

Currently, the let_and_return lint is always triggered. I have quite a lot of code which looks like:

let something = match something_else {
    Variant1 => { /* something */},
    ...
    Variant_some_very_large_number => { /* whatever */ }
};

something

Here, I believe it is a lot clearer to explicitly have the let binding, since you may have to scroll quite far to see that there's no semi-colon at the end of the match block for it to be obvious that it's the return expression. I don't know what a suitable size threshold would be, or even if it's possible to reasonably make restrictions based on that.

Of course, I'm open to other ways of writing code blocks like this which would also solve the issue!

コントリビューターガイド

技術スタック
rust
領域
developer experiencetooling
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Rust programmingClippy contribution basicsAST understanding
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
Examine the current implementation of the `let and return` lint in `clippy lints/src/let and return.rs`. Look at how other lints (e.g., `too many arguments`) implement thresholds via configuration. Check the issue comments for previous suggestions on threshold values. Consider adding a `let and return threshold` option to Clippy's configuration.