FR: redundant_field_names should distinguish between all and some fields matching · rust-lang/rust-clippy#3422

(1 comment) (4 reactions) (1 assignee)Rust (10,406 stars) (1,391 forks)batch import

C-enhancementL-stylegood first issue

説明

redundant_field_names fires on any field being a match. This impairs readability in cases like this:

let thingy = Thingy {
   calc: big + calculation,
   redundant: redundant,
   other: stuff.into(),
};

As you can see, if you apply the suggestion, you end up with a weird line that is different from the rest. I suggest that the lint be split such that it distinguishes between "all fields are redundant" and "some fields are redundant".

コントリビューターガイド

技術スタック: rust
領域: developer experiencetooling
Issue 種別: feature
難度: 3
推定時間: 1-2 days
活動状況: stale
明確さ: clear
前提条件: Rust programmingClippy lint development basics
初心者向け度: 50
調査方針: Examine the existing `redundant field names` lint implementation in the clippy source code. The current behavior triggers when any field matches. To implement the distinction, modify the lint to check each field individually and categorize whether some or all fields are redundant. This likely involves iterating over the struct fields and comparing names. The lint is in `clippy lints/src/`; find the relevant file and understand how lints are structured. Consider adding a new variant to the diagnostic message or splitting the lint into two separate categories. Review any comments or discussions in the issue for additional context.