rust-lang/rust-clippy

New lint: clone on arguments taken by reference

Open

#2,074 opened on 2017年9月19日

GitHub で見る
 (7 comments) (0 reactions) (1 assignee)Rust (10,406 stars) (1,391 forks)batch import
A-lintL-unnecessaryT-middlegood first issue

説明

If a function takes an argument by reference, but later calls .clone() on it (or otherwise requires an impl Clone or impl Copy from it), lint that taking it by ownership allows the caller to pass in its memory rather than forcing a clone on the data.

I don't know if this is possible, but can it default to allow on public functions and deny on crate-private functions (due to the API change)?

コントリビューターガイド

技術スタック
rust
領域
toolingdeveloper experience
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Rust programmingclippy internalsRust ownership model
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
35
調査方針
To implement this lint, the contributor should first understand clippy's lint infrastructure by examining existing lints in the `clippy lints` crate. They should look at how other lints detect patterns in function signatures and bodies. The issue's comment thread may provide additional clarification. The functionality should detect functions that accept a reference and later call `.clone()` on it, and suggest changing to ownership. The distinction between public and crate private functions should be considered, possibly using the `is in unconfigured public` or similar attribute.
New lint: clone on arguments taken by reference · rust-lang/rust-clippy#2074 | Good First Issue