rust-lang/rust-clippy
GitHub で見るRewrite `arithmetic_side_effects` to not use matching on string representation of types
Open
#16,359 opened on 2026年1月8日
C-enhancementgood first issue
Repository metrics
- Stars
- (10,406 stars)
- PR merge metrics
- (平均マージ 19d 22h) (30d で 113 merged PRs)
説明
Description
arithmetic_side_effects uses the string representation of types to compare them. This will miss aliases (including core/alloc → std), takes longer to compare, etc.
It should use a method similar to what is done in the disallowed_types lint, where maps of DefId or PrimTy are built at lint initialization time and then used throughout the tree walk. Some type lookup code could probably even be shared (including the part where unloaded crates don't cause errors).
Version
Additional Labels
No response