rust-lang/rust-clippy

`std_wildcard_imports` to lint against `use std::mod::*`

Open

#13,961 opened on 2025年1月7日

GitHub で見る
 (4 comments) (1 reaction) (1 assignee)Rust (10,406 stars) (1,391 forks)batch import
A-lintE-help-wantedgood first issue

説明

What it does

This is a version of wildcard_imports that affects only imports from the standard crates std, core, proc_macro, alloc, and test.

Advantage

wildcard_imports is in pedantic, which seems reasonable for most crates. However, using glob imports from the standard library means that upgrading Rust version can break the build. Recent examples:

I am proposing std_wildcard_imports as a separate lint from wildcard_imports so it can get enabled by default, likely in clippy::style (or possibly uplifted https://github.com/rust-lang/rust/issues/135672#issuecomment-2605426121)

Drawbacks

Confusion between wildcard_imports and std_wildcard_imports, noise on existing code, sometimes use proc_macro::* or similar is fine for testing.

Example

Lint on glob imports:

use std::mem::*; // error
use core::sync::*; // error
use proc_macro::*; // error

However, using glob imports from prelude modules should not raise this warning:

use std::io::prelude::*; // ok
use std::prelude::rust_2021:* // unlikely, but still ok

Non-std crates don't raise this lint

use regex::*; // ok

コントリビューターガイド

技術スタック
rust
領域
toolingdeveloper experience
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
blocked
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
RustClippy lint internals
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
The issue is assigned to alanbondarun. To implement, study existing lints like wildcard imports in clippy lints/src. Follow the pattern: add a new lint module, register it, and write tests. The lint should detect glob imports from std, core, proc macro, alloc, and test, but exclude prelude modules. See linked issues for rationale.