matching_brace function not correct when jumping from open brace to close brace · rust-lang/rust-analyzer#1942

(8 comments) (0 reactions) (0 assignees)Rust (14,924 stars) (1,726 forks)batch import

E-has-instructionsE-mediumS-actionablegood first issue

説明

swap the order of do_check parameters the makes the test case failed

do_check("struct Foo <|>{ a: i32, }", "struct Foo { a: i32, }<|>");

this matching behavior should be symmetrical

if the matching node is a left brace, we use start(), if the matching node is a right brace, we should use end()

技術スタック: rust
領域: developer experiencetooling
Issue 種別: bug
難度: 2
推定時間: under 1 hour
活動状況: stale
明確さ: clear
前提条件: Rustrust analyzer codebase
初心者向け度: 80
調査方針: The bug is in crates/ra ide api/src/matching brace.rs. The function do check currently uses start() for left brace but should use end() for right brace to ensure symmetry. The fix involves swapping the parameter order in the test case and adjusting the check for right brace to use end(). No linked PRs or maintainer questions; the issue is self contained.