rtfeldman/seamless-immutable

isMergableObject returns true for an empty object

オープン

#82 opened on 2015/12/28

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (221 件のフォーク)batch import
bughelp wanted

Repository metrics

Stars
 (5,367 個のスター)
PR merge metrics
 (PR metrics pending)

説明

      function addToResult(currentObj, otherObj, key) {
      var immutableValue = Immutable(otherObj[key]);
      var mergerResult = merger && merger(currentObj[key], immutableValue, config);
      var currentValue = currentObj[key];

      console.log("IS NEW OBJECT MERGABLE", isMergableObject(new Object()));

  -> seamless-immutable.js:306 IS NEW OBJECT MERGABLE true

In my production build currentValue is sometimes an empty object, and with deep merge enabled we error out when trying to call merge() on said object. In dev mode this never seems to happen.

I've worked around this with an additional check to isMergableObject which checks that Object.keys(target).length > 0. If this seems like an acceptable fix I'd love to submit a PR.

コントリビューターガイド