rescript-lang/rescript-vscode

parseCompilerLogOutput crashes when first error is graphql deprecation warning

オープン

#386 opened on 2022/04/07

 (12 件のコメント) (0 件のリアクション) (1 人の担当者)ReScript (63 件のフォーク)github user discovery
buggood first issuehelp wanted

Repository metrics

Stars
 (350 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

Hi Folks. Found a case here. given a codebase using rescript-apollo, with a deprecated field warning, the parser will fail its "File " branch based on the next line not being Warning, and end up in its last case where it attempts to push a follow up line to an empty parsedDiagnostics array.

I can see some pushback on the apollo output here maybe, but would it be better to make the "File " branch more permissive, or allow a new parsed diagnostic to be created there in that non-empty-line case?

Thanks Alex

File "/Users/alexmouton/Documents/code/noble/web/src/packs/reactor/PackCapabilityRunSweepUpdateHf.res", line 45, characters 8-26:
45 | ........entDataRecordId
45 |   .....
Warning 22 [preprocessor]: Field "parentDataRecordId" has been deprecated. Reason: Prefer parent_data_record
File "/Users/alexmouton/Documents/code/noble/web/src/packs/reactor/PackCapabilityRunSweepUpdateHf.res", line 42, characters 40-53:
42 | ........................................ectedInput
42 |   .......

コントリビューターガイド