renovatebot/renovate

Support vendored major upgrades for Go

Open

#21,010 opened on 2023年3月17日

GitHub で見る
 (9 comments) (20 reactions) (0 assignees)TypeScript (14,066 stars) (1,916 forks)batch import
help wantedmanager:gomodpriority-3-medium

説明

What would you like Renovate to be able to do?

Update major versions in projects that have Go vendoring enabled.

Eg. github.com/google/go-github/v48 to github.com/google/go-github/v50

Reproduction repository: https://gitlab.com/hugoboos/renovate-go-update-import

Related discussion: https://github.com/renovatebot/renovate/discussions/20996

If you have any ideas on how this should be implemented, please tell us here.

At the moment Renovate updates go.mod. This should be done by the mod tool. This tool is already being used by Renovate. Only the order should be changed.

  1. Run mod to change the import paths
  2. Run go mod tidy, this will update go.mod. Possible that version is different from that Renovate selected.
  3. Change the version in go.mod for the updated package.
  4. Run go mod tidy
  5. Run go mod vendor
  6. Commit

Is this a feature you are interested in implementing yourself?

No

コントリビューターガイド

技術スタック
gotypescript
領域
toolingdeveloper experience
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
active
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Understanding of Go module versioningFamiliarity with Renovate codebaseExperience with Go vendoring
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Examine the Renovate source code for the Go module manager (likely under lib/modules/manager/gomod). Understand how the 'mod' tool currently updates import paths. Implement the proposed order: run mod to change import paths, then go mod tidy, adjust version in go.mod, run go mod tidy again, then go mod vendor, and commit. Reference the reproduction repository at https://gitlab.com/hugoboos/renovate go update import and the related discussion at https://github.com/renovatebot/renovate/discussions/20996 for testing.