remixz/publish-release

Cope better with `EDITOR` not being defined

Open

#6 opened on 2015年8月17日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (17 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (72 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

There are a couple of ways this could be achieved:

  1. Fail-fast with a nice error message if EDITOR has not been defined.
  2. Ask the developer to enter the path to their editor in lieu of EDITOR not being defined.

Ideally, my preference would be for option 2, as I plan to use publish-release within the postpublish hook of all our modules, and this would allow developers who run npm publish to still have things work, rather than requiring them to define EDITOR, then re-run npm run postpublish.

コントリビューターガイド