recloudstream/cloudstream

Improve delayed updater triggering method

Open

#1,282 opened on 2024年8月16日

GitHub で見る
 (2 comments) (1 reaction) (0 assignees)Kotlin (9,642 stars) (877 forks)batch import
enhancementgood first issue

説明

Describe your suggested feature

Currently actually updating is done in onPause() in MainActivity, this causes inconsistent and unexpected triggering behavior. I suggest we move this to onDestroy() And add a persistent notification that says something like "Update now" on mobile, and auto stop app when you click update on TV. This is because onPause() is also triggered when you enter PiP mode or switch activities such as going to "Manage Accounts". I understand the reason for waiting is for user choice but the current implementation I don't think actually indicates "user choice" as if you forget about it or something and go home you inadvertently start the update which force stops the app. To me, this is bad behaviour.

Other details

No response

Acknowledgements

  • My suggestion is NOT about adding a new provider
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

コントリビューターガイド

技術スタック
kotlinandroid
領域
mobile
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Android lifecycleKotlin basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
The solution involves moving the update triggering code from onPause() to onDestroy() in MainActivity. A persistent notification with an 'Update now' action should be added. Start by examining the current update logic in MainActivity's onPause() method (likely in the cloudstream Android app). Then migrate that logic to onDestroy() and create a notification using Android's NotificationManager. Ensure that the notification includes a PendingIntent to trigger the update when clicked. Also consider the behavior for PiP (picture in picture) mode to avoid triggering the update inadvertently.