realm/SwiftLint

Feature request: Add an option that changes behavior depending on whether attributes have arguments

Open

#5,011 opened on 2023年5月15日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)Swift (19,570 stars) (2,295 forks)batch import
enhancementgood first issue

説明

New Issue Checklist

New feature request

The attributes_with_arguments_always_on_line_above option which has added to the attributes rule in version 0.52.0 is only working for variables and imports. I think it would be nice if there was a way to work for functions and types as well.

In the current version, variables and imports can change the behavior of the attributes rule depending on whether their attributes have arguments, but functions and types cannot. I think it would be nice if they had a way to do the same.

An use case:

@objc(Foo)
class Foo: NSObject {
    @objc func foo() {}
}

ref. Google's Swift Style Guide

コントリビューターガイド

技術スタック
swift
領域
tooling
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Swift programmingbasic SwiftLint rule structure
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
The issue requests extending the `attributes with arguments always on line above` option to functions and types in the `attributes` rule. Currently, the option only works for variables and imports. The implementation likely involves modifying the rule's logic in the SwiftLint source code to handle function and type declarations similarly. Refer to the existing implementation of the `attributes` rule, specifically how it checks for attribute arguments and enforces line placement. The change should be localized to the rule's file, possibly `AttributesRule.swift`.
Feature request: Add an option that changes behavior depending on whether attributes have arguments · realm/SwiftLint#5011 | Good First Issue