reactorlabs/rir

support for named indices

オープン

#798 opened on 2020/01/24

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)C++ (19 件のフォーク)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (61 個のスター)
PR merge metrics
 (平均マージ 1m) (30d で 1 merged PR)

説明

The description here depends on some type inference inprovements in #797

Reproduce

run with PIR_DEBUG=PrintPirAfterOpt

f <- function() {
  a <- c(1,2,3)
  names(a) <- c("one", "two", "three")
  a['one'] + a['two']
}
f()
f()
f()

Observe that the result contains:

  str$"           %2.4  = LdConst                  [1] "one" 
  real$'<real'>   %2.5  = Extract1_1D        wed   %2.3, %2.4, elided

there are two issues here:

  1. the index of "one" is computed at runtime
  2. the result is tagged, because it has an attribute (ie. a name)

Resolving issue (2) is probably a longterm goal, that needs many changes. but (1) should be approachable.

Possible Solution

Currently our type feedback records if a value has attributes (except dimension attrs of matrix) here. We could extend this to specifically record the names attribute.

If the names attribute is stable, we could speculate on it and compute the index at compile time.

コントリビューターガイド