reactor/reactor-core

Improve Flux.timeout efficiency

Open

#2,845 opened on 2021年11月21日

GitHub で見る
 (17 comments) (3 reactions) (0 assignees)Java (1,164 forks)batch import
area/performancefor/user-attentionhelp wanted

Repository metrics

Stars
 (4,748 stars)
PR merge metrics
 (平均マージ 16d 15h) (30d で 25 merged PRs)

説明

Current implementation uses parallel scheduler by default which is in essence a ScheduledThreadPoolExecutor which has the task queue guarded by ReentrantLock, which means two trips through said lock per signal on average

After looking at Netty's https://github.com/netty/netty/blob/4.1/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java there appears to be a way to do fewer timeout task reschedules if you let go of the idea illustrated by the current marble diagrams (new signal cancels the previous timeout task)

WDYT? this really prevents Flux.timeout from being useful with high-frequency publishers which may occasionally stall

suggestion inspired by https://gitter.im/reactor/reactor?at=61968a44197fa95a1c7adf05

コントリビューターガイド