react-dropzone/react-dropzone

Cannot get file dialog to open on Safari when changing dropzone attr in action chain

Open

#1,188 opened on 2022年5月3日

GitHub で見る
 (8 comments) (0 reactions) (0 assignees)JavaScript (10,254 stars) (779 forks)batch import
bughelp wantedneeds investigation

説明

Expected Behavior

Dialog opens on click of button with new attr taken into consideration

Actual Behavior

In Safari, double click is required to launch the open function if there is a chain of actions required

Steps to Reproduce the Problem

https://codesandbox.io/s/react-dropzone-example-forked-wn64on?file=/src/App.js:927-974

  1. Have different options for dropzone attr (accept used in example)
  2. Have multiple buttons in order to set attr and launch a chain of events which end in dialog box opening 2.1. If you setState and open in the same event open will happen before state is set
  3. Click on buttons, double click necessary.

In a more complex application, no amount of clicking makes the dialog open, but I wasn't able to reproduce in code sandbox. I'm hoping that the issues are related.

Real world example UI image

Specifications

  • Version: "^14.0.0", original issue found in version "^4.2.9"
  • Platform: Mac 11.6.4
  • Subsystem: Safari Version 15.3

コントリビューターガイド

技術スタック
javascriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
React hooksUnderstanding of state batchingKnowledge of file input dialog
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
35
調査方針
The issue involves Safari requiring double clicks when changing dropzone attributes before opening the file dialog. Investigate the useDropzone hook to see how the open function is triggered and how it interacts with React state updates. The provided CodeSandbox should be tested on Safari to reproduce. Potential fix may involve ensuring the dialog opens after state is updated, possibly using useEffect or a setTimeout. Look at existing discussions in the issue comments for any insights.