react-bootstrap-table/react-bootstrap-table2

Add callback when editing on cell is cancelled

Open

#684 opened on 2018年11月26日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,249 stars) (415 forks)batch import
cell-editorgood first issuehelp wanted

説明

In version 1.2.2 of react-bootstrap-table2-editor, it is possible to be notified when a cell enters the editing state using onStartEdit. However, if blurToSave is set to false, there is no way to determine that editing was cancelled when the user clicks away from the editing cell and the cell transitions back to a non-editing state. It would be very useful to have a onEditCancel (or some other appropriate name) callback method that could be set for this case. When blurToSave is true, all is fine as any change in focus, leads to the afterCellSave method to be called.

コントリビューターガイド

技術スタック
reactjavascript
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Reactreact bootstrap table2 basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
80
調査方針
Examine the current implementation of cell editing in the package, specifically the onStartEdit callback and how the cell transitions between editing and non editing states when blurToSave is false. Look at the source code for the cell editor component to understand where to hook in a new onEditCancel prop. Consider how to differentiate between save and cancel events, and ensure the new callback is only triggered on cancellation. Check existing tests for similar callbacks to follow the pattern.
Add callback when editing on cell is cancelled · react-bootstrap-table/react-bootstrap-table2#684 | Good First Issue