CUDA/C++good first issue
Repository metrics
- Stars
- (5,223 stars)
- PR merge metrics
- (PR metrics pending)
説明
This came up in https://github.com/rapidsai/cuml/pull/6525 which attempted to remove ODR violations, and we noticed that check-symbols in CI fails even after removing the ODR violations. This is due to the fact that these kernels are called across TU boundaries and the issue is separate from satisfying ODR.
The fix for check-symbols was to mark the kernels as static. Per @vyasr https://github.com/rapidsai/cuml/pull/6525#issue-2984054211, we should define preprocessor macros that standardize how we annotate our kernel and device functions in cuML.