rapidsai/cudf

[FEA] Add overload for `set_null_mask` that accept result of `make_null_mask` directly

オープン

#13,154 opened on 2023/04/17

 (1 件のコメント) (0 件のリアクション) (1 人の担当者)C++ (735 件のフォーク)batch import
0 - Backlogfeature requestgood first issuelibcudf

Repository metrics

Stars
 (6,000 個のスター)
PR merge metrics
 (平均マージ 17d 21h) (30d で 230 merged PRs)

説明

Currently, we have the make_null_mask API returning both null mask and null count:

template <typename ValidityIterator>
std::pair<rmm::device_buffer, cudf::size_type> make_null_mask(ValidityIterator begin,
                                                              ValidityIterator end)

However, the set_null_mask function can't accept that result. As such, we have to pass the result of make_null_mask into set_null_mask by two steps:

auto [null_mask, null_count] =
    cudf::test::detail::make_null_mask(valid_iter, valid_iter + input.size());
  output.set_null_mask(std::move(null_mask), null_count);

This is a bit inconvenient. We can do that in just one step like this:

output.set_null_mask(cudf::test::detail::make_null_mask(valid_iter, valid_iter + input.size()));

In order to do that, we need to have a new overload of set_null_mask that accept the return type of make_null_mask such as:

void set_null_mask(std::pair<rmm::device_buffer, cudf::size_type>&&) { ... }

コントリビューターガイド