raphamorim/react-ape

fix publish GH workflow: publish and tests should not run tests twice

オープン

#126 opened on 2022/06/30

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (47 件のフォーク)github user discovery
good first issue

Repository metrics

Stars
 (1,574 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

Currently the Publish workflow runs together with test, executing the same yarn ci (running tests again) it shouldn't be happening. Should wait for the test workflow check and the follow up with publish.

There's few approaches that could fix it:

  • check if the tests have passed
  • move the publish workflow to tests as a step but only runs if commit message have [publish]

コントリビューターガイド