qmk/qmk_firmware

[Bug] Key overrides are not performed on keys processed as a tap of a mod-tap

Open

#22,848 opened on 2024年1月7日

GitHub で見る
 (1 comment) (2 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (平均マージ 20d 9h) (30d で 27 merged PRs)

説明

Describe the Bug

A keycode produced as the tap portion of a mod-tap key is not replaced with its correct override.

Keyboard Used

klor

Link to product page (if applicable)

No response

Operating System

mac

qmk doctor Output

Ψ QMK Doctor is checking your environment.
Ψ CLI version: 1.1.2
Ψ QMK home: /Users/chad/qmk_firmware
Ψ Detected macOS 14.2.1 (Intel).
Ψ Userspace enabled: False
Ψ Git branch: master
⚠ Git has unstashed/uncommitted changes.
Ψ - Latest master: 2023-12-29 17:17:20 +0100 (fc20e0b014) -- Waffling60 iso rev e (#22733)
Ψ - Latest upstream/master: 2024-01-06 02:06:14 +0100 (a474cac2c3) -- Update keymap.md (#22834)
Ψ - Latest upstream/develop: None
Ψ - Common ancestor with upstream/master: 2023-12-29 17:17:20 +0100 (fc20e0b014) -- Waffling60 iso rev e (#22733)
Ψ - Common ancestor with upstream/develop: None
Ψ CLI installed in virtualenv.
Ψ All dependencies are installed.
Ψ Found arm-none-eabi-gcc version 8.5.0
Ψ Found avr-gcc version 8.5.0
Ψ Found avrdude version 7.2
Ψ Found dfu-programmer version 1.1.0
Ψ Found dfu-util version 0.11
Ψ Submodules are up to date.
Ψ Submodule status:
Ψ - lib/chibios: 2023-04-15 13:48:04 +0000 --  (11edb1610)
Ψ - lib/chibios-contrib: 2023-07-17 11:39:05 +0200 --  (da78eb37)
Ψ - lib/googletest: 2021-06-11 06:37:43 -0700 --  (e2239ee6)
Ψ - lib/lufa: 2022-08-26 12:09:55 +1000 --  (549b97320)
Ψ - lib/vusb: 2022-06-13 09:18:17 +1000 --  (819dbc1)
Ψ - lib/printf: 2022-06-29 23:59:58 +0300 --  (c2e3b4e)
Ψ - lib/pico-sdk: 2023-02-12 20:19:37 +0100 --  (a3398d8)
Ψ - lib/lvgl: 2022-04-11 04:44:53 -0600 --  (e19410f8)
Ψ QMK is ready to go, but minor problems were found

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

All other key overrides are processed correctly (ie, on tapped keys that are not mod-tap keys), including when the modifier needed to activate the override is provided by a held mod-tap key.

コントリビューターガイド