qmk/qmk_firmware

[Bug] CAPS_WORD: '-' with hold OSL gives _, but with tap OSL gives -

Open

#18,136 opened on 2022年8月22日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (平均マージ 20d 9h) (30d で 27 merged PRs)

説明

Describe the Bug

With CAPS_WORD off:

  • hold or tap OSL, tap - gives -

With CAPS_WORD on:

  • hold OSL, tap - gives _
  • tap OSL, tap - gives -

To reproduce:

Keymap with -_ on a OSL.

  • Hold OSL, tap -
  • Tap OSL, tap -

Activate CAPS_WORD

  • Type some letters to verify CAPS_WOD
  • Hold OSL, tap -
  • Tap OSL, tap -
  • Type some letters

Results:

OFF: HH--HH
ON:  HH_-HH

Tested on

Master and dev with Hillside 52 default_dot_c keymap, a vanilla keymap, with MO(_SYM) changed to OSL(_SYM)

https://github.com/qmk/qmk_firmware/blob/master/keyboards/handwired/hillside/52/keymaps/default_dot_c/keymap.c

System Information

Keyboard: Hillside 52 Revision (if applicable): Operating system: OS X qmk doctor output:

Ψ QMK Doctor is checking your environment.
Ψ CLI version: 1.0.0
Ψ QMK home: /Users/xxxxxx/qmk_firmware
Ψ Detected macOS 11.6.8 (Intel).
Ψ Git branch: develop
Ψ Repo version: 0.17.9
⚠ Git has unstashed/uncommitted changes.
⚠ The official repository does not seem to be configured as git remote "upstream".
Ψ CLI installed in virtualenv.
Ψ All dependencies are installed.
Ψ Found arm-none-eabi-gcc version 8.3.1
Ψ Found avr-gcc version 8.4.0
Ψ Found avrdude version 6.3
Ψ Found dfu-util version 0.11
Ψ Found dfu-programmer version 0.7.2
Ψ Submodules are up to date.
Ψ Submodule status:
Ψ - lib/chibios: 2022-06-11 09:09:45 +0000 --  (f836d24b0)
Ψ - lib/chibios-contrib: 2022-07-27 10:46:15 +0200 --  (d03aa9cc)
Ψ - lib/googletest: 2021-06-11 06:37:43 -0700 --  (e2239ee6)
Ψ - lib/lufa: 2022-06-12 22:00:28 +1000 --  (35cc3d92f)
Ψ - lib/pico-sdk: 2022-05-17 19:19:01 +0200 --  (07edde8)
Ψ - lib/printf: 2022-06-29 23:59:58 +0300 --  (c2e3b4e)
Ψ - lib/vusb: 2022-06-13 09:18:17 +1000 --  (819dbc1)
Ψ QMK is ready to go, but minor problems were found

Git diff

(py39)  qmk_firmware_hillside_fork % git diff
diff --git a/keyboards/handwired/hillside/52/keymaps/default_dot_c/keymap.c b/keyboards/handwired/hillside/52/keymaps/default_dot_c/keymap.c
index f0c5b755d5..88b379baba 100644
--- a/keyboards/handwired/hillside/52/keymaps/default_dot_c/keymap.c
+++ b/keyboards/handwired/hillside/52/keymaps/default_dot_c/keymap.c
@@ -13,7 +13,7 @@ enum layers {
 #define xxxxxxx KC_NO
 
 #define LY_NAV MO(_NAV)
-#define LY_SYM MO(_SYM)
+#define LY_SYM OSL(_SYM)
 #define LY_ADJ MO(_ADJUST)
 #define ALT_GR OSM(MOD_RALT)
 #define OSM_SFT OSM(MOD_LSFT)

Any keyboard related software installed?

  • AutoHotKey (Windows)
  • Karabiner (macOS)
  • Other:

Additional Context

コントリビューターガイド