qmk/qmk_firmware

[Bug] Unnecessary delay when pressing the first key after a One-shot key

オープン

#14,932 opened on 2021/10/24

 (4 件のコメント) (1 件のリアクション) (0 人の担当者)C (43,867 件のフォーク)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 個のスター)
PR merge metrics
 (平均マージ 20d 9h) (30d で 27 merged PRs)

説明

One-shot has 2 behaviors:

  • When the mod-key is tapped, the following keypress is modified
  • When the mod-key is held, all keypresses during the hold are modified

This leads to a necessary delay because if the modifier and then "a" and "b" are pressed in rapid succession, we don't yet know if the mod-key press is a tap or a hold, so we don't know whether to apply the modifier to "b" or not.

However, there the delay is unnecessary for "a". In either case (tap or hold), "a" will be modified, so we can send the modified keypress right away.

コントリビューターガイド