qmk/qmk_firmware

[Bug] keycode from LT/MT still registers in Music

オープン

#10,920 opened on 2020/11/11

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)C (43,867 件のフォーク)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 個のスター)
PR merge metrics
 (平均マージ 20d 9h) (30d で 27 merged PRs)

説明

Describe the Bug

When activating the music mode, the mask is unable to stop the keycode from being output. Normally, it does this by returning false in process_music, but this doesn't stop the LT or MT keycodes from being emitted, as it happens in tmk_core/common/action.c rather than in quantum.

System Information

  • Keyboard: Moonlander, Planck EZ, but really any with audio
  • Operating system: Win, Mac
  • AVR GCC version: 8.x
  • ARM GCC version: 8.x
  • QMK Firmware version: latest

コントリビューターガイド