qmk/qmk_firmware

[Bug] Playing audio in music mode more than 11000 frequency render my keyboard useless

Open

#10,556 opened on 2020年10月5日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)C (43,867 forks)batch import
bughelp wanted

Repository metrics

Stars
 (20,368 stars)
PR merge metrics
 (平均マージ 20d 9h) (30d で 27 merged PRs)

説明

Describe the Bug

the music mode will make the keyboard laggy or useless when playing high frequency (more than 11000) in music mode. my fix is to map audio changing the last key to the low number so the last key not generating more than 11000 frequency.

const uint8_t music_map[MATRIX_ROWS][MATRIX_COLS] = KEYMAP(
       59, 60, 61, 62, 63, 64,     0,  1,  2,  3,  4,  5,  6,  7,
       45, 46, 47, 48, 49, 50,    51, 52, 53, 54, 55, 56, 57, 58,
       31, 32, 33, 34, 35, 36,    37, 38, 39, 40, 41, 42, 43, 44,
   16, 17, 18, 19, 20, 21, 22,    23, 24, 25, 26, 27, 28, 29, 30,
0,  1,  2,  3,  4,  5,  6,  7,     8,  9, 10, 11, 12, 13, 14, 15
);

there should be a way to limit the max frequency allowed in music mode. like the clicky mode.

System Information

  • ARM GCC version: 8.3.1
  • QMK Firmware version: 0.10.25
  • Any keyboard related software installed?
    • AutoHotKey
    • Karabiner
    • Other:

Additional Context

コントリビューターガイド