pytorch/ignite

`Timer`'s misleading behaviour when epoch completion time calculated

Open

#2,157 opened on 2021年8月11日

GitHub で見る
 (7 comments) (1 reaction) (1 assignee)Python (4,313 stars) (602 forks)batch import
HacktoberfestPyDataGlobalenhancementhelp wanted

説明

When I tried calculating the time taken to complete a single epoch via Timer, the handlers attached to trainer before Timer were executed first, and thus their time also got recorded by the Timer too for a single epoch. Therefore the true time taken for epoch completion, provided by trainer.state.times, is less than what Timer calculated. This can be misleading. More clarification on how this actually works in the docs would be appreciated. Or the Timer's functionality can be enhanced to step before all other handlers attached to an event could also be helpful. Notebook to quickly verify this here.

コントリビューターガイド

技術スタック
pythonpytorch
領域
machine learningdeveloper experience
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Familiarity with PyTorch Ignite event system
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
Examine the Timer implementation in PyTorch Ignite, specifically how it hooks into events. The issue suggests that Timer should step before other handlers. Check the source code for the Timer class and its event registration. Consider whether a simple reordering of handler execution or a new event attribute is needed. The provided Colab notebook can be used to reproduce the issue.
`Timer`'s misleading behaviour when epoch completion time calculated · pytorch/ignite#2157 | Good First Issue